Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/tidb-tools): add integration tests #3000

Merged

Conversation

purelind
Copy link
Collaborator

add integration tests

Copy link

ti-chi-bot bot commented Jun 14, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request adds integration tests to the pingcap/tidb-tools pipeline. The changes include adding a new stage for Integration Test, downloading and extracting artifacts, and running integration tests. The integration tests include checking if the required binaries are present, testing MySQL connection, and running the integration tests.

Some potential problems that could arise from this pull request include:

  • The integration test stage is missing a dependency check to ensure that the necessary files are present before running the tests.
  • The make integration_test command does not have any arguments to specify which tests to run, which could lead to running all tests instead of just the necessary ones.
  • The post-build section archives artifacts and prints the logs, but it does not specify where to store these logs, which could lead to confusion in case of multiple builds.

To fix these issues, I suggest the following:

  • Add a dependency check before running the integration tests to ensure that all necessary files are present.
  • Add arguments to the make integration_test command to specify which tests to run.
  • Specify the location to store the archived artifacts and logs in the post-build section.

@ti-chi-bot ti-chi-bot bot added the size/M label Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 8b5cd22 into PingCAP-QE:main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant